Skip to content

Conversation

@gonfunko
Copy link
Contributor

This PR fixes #286 by removing the next/previous sibling, jump to root and context in/out actions, along with supporting functions used only by those actions.

@gonfunko gonfunko requested a review from a team as a code owner March 10, 2025 21:36
@gonfunko gonfunko requested review from BenHenning and removed request for a team March 10, 2025 21:36
@cpcallen
Copy link
Collaborator

Can we hold off on submitting this until we have another way to move the cursor to the workspace?

@rachel-fenichel
Copy link
Collaborator

What other way are you suggesting?
I'd prefer to submit this and add an explicit action to move the cursor to the workspace, probably in the same file as the rest of workspace movement, rather than keep all of these around just in case.

Copy link
Collaborator

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gonfunko!

@gonfunko gonfunko merged commit 9b9ffc8 into main Mar 12, 2025
3 checks passed
@gonfunko gonfunko deleted the complex-actions branch March 12, 2025 17:20
@cpcallen
Copy link
Collaborator

cpcallen commented Mar 13, 2025

What other way are you suggesting? I'd prefer to submit this and add an explicit action to move the cursor to the workspace, probably in the same file as the rest of workspace movement, rather than keep all of these around just in case.

Well, ultimately unconstrained cursor movement, as described in #129, but for now any other way: we have left ourselves in a position where the only way to test the worksapce cursor, workspace context menu, and any new actions that appear therein, is to place a new top-level block and then delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused actions for complex movement

5 participants